modules: hal_nordic: multi-instance DPPI minor fixes #81602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
hubertmis,
jaz1-nordic,
kl-cruz,
krish2718,
magp-nordic,
masz-nordic,
nika-nordic,
nordic-krch and
sachinthegreen
e-rk
added a commit
to e-rk/sdk-zephyr
that referenced
this pull request
Nov 19, 2024
…ader The resource reservation header is now included according to a Kconfig value. The Kconfig can be overriden out-of-tree in case a different header is needed. Upstream PR: zephyrproject-rtos/zephyr#81602 Signed-off-by: Rafał Kuźnia <[email protected]>
e-rk
added a commit
to e-rk/sdk-zephyr
that referenced
this pull request
Nov 19, 2024
Changed the CMakeLists to enable the nrfx_gppi utilities based solely on the CONFIG_NRFX_GPPI Kconfig. This unifies the configuration on all nRF SoC families. Upstream PR: zephyrproject-rtos/zephyr#81602 Signed-off-by: Rafał Kuźnia <[email protected]>
e-rk
added a commit
to e-rk/sdk-zephyr
that referenced
this pull request
Nov 19, 2024
The NRF54L_SERIES define is more specific and should be used in favor of LUMOS_XXAA. Upstream PR: zephyrproject-rtos/zephyr#81602 Signed-off-by: Rafał Kuźnia <[email protected]>
e-rk
added a commit
to e-rk/sdk-zephyr
that referenced
this pull request
Nov 19, 2024
Added dppic0 node label, alongside the dppic to maintain backward compatibility. The use of dppic0 is preferred. Upstream PR: zephyrproject-rtos/zephyr#81602 Signed-off-by: Rafał Kuźnia <[email protected]>
e-rk
added a commit
to e-rk/sdk-zephyr
that referenced
this pull request
Nov 19, 2024
…ader The resource reservation header is now included according to a Kconfig value. The Kconfig can be overriden out-of-tree in case a different header is needed. Upstream PR: zephyrproject-rtos/zephyr#81602 Signed-off-by: Rafał Kuźnia <[email protected]>
e-rk
added a commit
to e-rk/sdk-zephyr
that referenced
this pull request
Nov 19, 2024
Changed the CMakeLists to enable the nrfx_gppi utilities based solely on the CONFIG_NRFX_GPPI Kconfig. This unifies the configuration on all nRF SoC families. Upstream PR: zephyrproject-rtos/zephyr#81602 Signed-off-by: Rafał Kuźnia <[email protected]>
e-rk
added a commit
to e-rk/sdk-zephyr
that referenced
this pull request
Nov 19, 2024
The NRF54L_SERIES define is more specific and should be used in favor of LUMOS_XXAA. Upstream PR: zephyrproject-rtos/zephyr#81602 Signed-off-by: Rafał Kuźnia <[email protected]>
e-rk
added a commit
to e-rk/sdk-zephyr
that referenced
this pull request
Nov 19, 2024
Added dppic0 node label, alongside the dppic to maintain backward compatibility. The use of dppic0 is preferred. Upstream PR: zephyrproject-rtos/zephyr#81602 Signed-off-by: Rafał Kuźnia <[email protected]>
e-rk
added a commit
to e-rk/sdk-zephyr
that referenced
this pull request
Nov 19, 2024
…tforms Changed the CMakeLists to enable the nrfx_gppi utilities based solely on the CONFIG_NRFX_GPPI Kconfig. This unifies the configuration on all nRF SoC families. Upstream PR: zephyrproject-rtos/zephyr#81602 Signed-off-by: Rafał Kuźnia <[email protected]>
e-rk
added a commit
to e-rk/sdk-zephyr
that referenced
this pull request
Nov 19, 2024
…RIES The NRF54L_SERIES define is more specific and should be used in favor of LUMOS_XXAA. Upstream PR: zephyrproject-rtos/zephyr#81602 Signed-off-by: Rafał Kuźnia <[email protected]>
e-rk
added a commit
to e-rk/sdk-zephyr
that referenced
this pull request
Nov 19, 2024
Added dppic0 node label, alongside the dppic to maintain backward compatibility. The use of dppic0 is preferred. Upstream PR: zephyrproject-rtos/zephyr#81602 Signed-off-by: Rafał Kuźnia <[email protected]>
anangl
reviewed
Nov 20, 2024
modules/hal_nordic/nrfx/Kconfig
Outdated
Comment on lines
34
to
35
There was a problem hiding this comment.
There's no need to check both these labels. dppic0 is enough.
Suggested change
| depends on ($(dt_nodelabel_has_compat,dppic,$(DT_COMPAT_NORDIC_NRF_DPPIC)) || \ | |
| $(dt_nodelabel_has_compat,dppic0,$(DT_COMPAT_NORDIC_NRF_DPPIC))) | |
| depends $(dt_nodelabel_has_compat,dppic0,$(DT_COMPAT_NORDIC_NRF_DPPIC)) |
modules/hal_nordic/nrfx/nrfx_glue.h
Outdated
There was a problem hiding this comment.
Is it actually possible that this will not be defined?
There was a problem hiding this comment.
It shouldn't be, but I was asked to add it regardless before making the PR.
The resource reservation header is now included according to a Kconfig value. The Kconfig can be overriden out-of-tree in case a different header is needed. Signed-off-by: Rafał Kuźnia <[email protected]>
Changed the CMakeLists to enable the nrfx_gppi utilities based solely on the CONFIG_NRFX_GPPI Kconfig. This unifies the configuration on all nRF SoC families. Signed-off-by: Rafał Kuźnia <[email protected]>
The NRF54L_SERIES define is more specific and should be used in favor of LUMOS_XXAA. Signed-off-by: Rafał Kuźnia <[email protected]>
Added dppic0 node label, alongside the dppic to maintain backward compatibility. The use of dppic0 is preferred. Signed-off-by: Rafał Kuźnia <[email protected]>
anangl
approved these changes
Dec 3, 2024
bjarki-andreasen
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed remaining comments from PR #79857
Added a Kconfig value that allows for changing the resource reservation header file.